Sybase CODE REVIEW CHECKLIST
|
No. |
Item |
|
1 |
Standards/documentation |
|
|
Database objects names less than or equal to 30 characters |
|
|
Stored procedures P<event type>_< procedure_name >. Event Type: P – Process, S – Select, I – Insert, U – Update, D – Delete, IU – Insert/Update |
|
|
Conformance to coding standards Naming conventions to be followed for database objects such as tables,indexes,views,constraints,triggers. |
|
|
Documentation in code: Sufficient Redundant Correct (conforms to code) |
|
|
|
|
2 |
Logic coverage |
|
|
Programming logic: correct (conforms to specifications) Use transactions inside stored procedures and check the return status . |
|
|
|
|
3. |
Data reference |
|
|
Variables initialized with proper datatype and size. Specify Null and output,if required |
|
|
No unused variables. |
|
|
Define global variables for error checking and count. |
|
|
|
|
4 |
Control flow |
|
|
Condition for loop termination exists(while, if-else) .No abnormal exits. |
|
|
Loops to have break/continue for exception handling. |
|
|
Boundary conditions and value range covered |
|
|
GOTO for looping purposes. |
|
|
|
|
5. |
Interface |
|
|
Datatypes of parameters passed/ received are consistent |
|
|
Lengths of parameters passed/received are correct |
|
|
Return codes correct. |
|
|
|
|
6. |
Formatting and indentation |
|
|
Blocks for header,declaration,executable and exception sections. |
|
|
Proper indentation within the blocks. |
|
|
Proper formatting for DDL and DML statements. |
|
|
|
|
7. |
Others |
|
|
Comments for understanding logic flow. |
|
|
No unused functions/code. |
|
|
Raise error messages, if any. |
|
|
|


Leave a Reply